Fix: Adjust HTML page title to customized AppTitle #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, this causes an empty title tag when the customize option is not used. Fixing. |
The existing customize feature only changed the title in the navbar.
sorcix
force-pushed
the
feature/customize-html-title
branch
from
e776a01
to
faccb17
Compare
- Move application of fixes into loader function - Remove default fallback from frontend source - Fix documentation of default value in AppTitle Signed-off-by: Knut Ahlers <knut@ahlers.me>
Luzifer
approved these changes
Aug 10, 2023
Luzifer
changed the title
Luzifer
added a commit
that referenced
this pull request
Aug 10, 2023
Co-authored-by: Knut Ahlers <knut@ahlers.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing customize feature only changed the title in the navbar.